RE: [PATCH v3 2/2] input: touchscreen: Add support for ILITEK Lego Series

Hi Dmitry,

Thank you for the quick response.
Would update Kconfig also in v4.

On Sun, Feb 28, 2021 at 21:25:13PM -0800, Dmitry Torokhov wrote:

Hi Joe,

On Fri, Feb 26, 2021 at 08:30:25AM +0000, Joe Hung (洪銘陽) wrote:

quoted

Hello Dmitry,

Thank you for the quick response.
Understand and agreed on all your comments.

Little question about the name of prefix and this driver file,
could it be named according to different protocol version named by ILITEK internally
as ilitek_p6x.c (as protocol version 6 for Lego series, and ili210x.c should be protocol 2).

In addition, could we named it like how touchscreen/elants_i2c.c and eftf2127.c worked?

So elants_i2c vs eftf2127 is historical artefact with elants_i2c being
there first.

quoted

Is there a way that we could keep ilitek as prefix and driver file's name?

OK, this is really a minor point as far as I am concerned and we spent
way too much time debating it. You may keep ilitek file name and prefix
if you would prefer. Just make sure you list supported
controllers/protocols in Kconfig and that should be enough.

Agreed; thank you very much.

Thanks.

-- 
Dmitry

Thank you very much.

--
Joe Hung