From: Lee Jones <hidden> Date: 2021-03-24 17:35:13
Fixes the following W=1 kernel build warning(s):
drivers/hid/intel-ish-hid/ishtp/client.c: In function ‘ishtp_cl_disconnect’:
drivers/hid/intel-ish-hid/ishtp/client.c:266:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable]
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <redacted>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/hid/intel-ish-hid/ishtp/client.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
From: Lee Jones <hidden> Date: 2021-03-24 17:35:13
Fixes the following W=1 kernel build warning(s):
In file included from drivers/hid/intel-ish-hid/ishtp-hid.c:11:
drivers/hid/intel-ish-hid/ishtp-hid.h:24:21: warning: ‘hid_ishtp_guid’ defined but not used [-Wunused-const-variable=]
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <redacted>
Cc: Daniel Drubin <redacted>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/hid/intel-ish-hid/ishtp-hid-client.c | 5 +++++
drivers/hid/intel-ish-hid/ishtp-hid.h | 5 -----
2 files changed, 5 insertions(+), 5 deletions(-)
@@ -11,6 +11,11 @@#include<linux/sched.h>#include"ishtp-hid.h"+/* ISH Transport protocol (ISHTP in short) GUID */+staticconstguid_thid_ishtp_guid=+GUID_INIT(0x33AECD58,0xB679,0x4E54,+0x9B,0xD9,0xA0,0x4D,0x34,0xF0,0xC2,0x26);+/* Rx ring buffer pool size */#define HID_CL_RX_RING_SIZE 32#define HID_CL_TX_RING_SIZE 16
From: Lee Jones <hidden> Date: 2021-03-24 17:35:14
Fixes the following W=1 kernel build warning(s):
drivers/hid/intel-ish-hid/ishtp/client.c:121: warning: Function parameter or member 'cl_device' not described in 'ishtp_cl_allocate'
drivers/hid/intel-ish-hid/ishtp/client.c:121: warning: Excess function parameter 'dev' description in 'ishtp_cl_allocate'
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <redacted>
Cc: Lee Jones <redacted>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/hid/intel-ish-hid/ishtp/client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Lee Jones <hidden> Date: 2021-03-24 17:35:14
Fixes the following W=1 kernel build warning(s):
drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'dev' not described in 'pidff_playback'
drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'effect_id' not described in 'pidff_playback'
drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'value' not described in 'pidff_playback'
drivers/hid/usbhid/hid-pidff.c:512: warning: expecting prototype for value times(). Prototype was for pidff_playback() instead
drivers/hid/usbhid/hid-pidff.c:1005: warning: Function parameter or member 'pidff' not described in 'pidff_find_effects'
drivers/hid/usbhid/hid-pidff.c:1005: warning: Function parameter or member 'dev' not described in 'pidff_find_effects'
drivers/hid/usbhid/hid-pidff.c:1005: warning: expecting prototype for Find the implemented effect types(). Prototype was for pidff_find_effects() instead
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <redacted>
Cc: Anssi Hannula <redacted>
Cc: linux-usb@vger.kernel.org
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/hid/usbhid/hid-pidff.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Lee Jones <hidden> Date: 2021-03-24 17:35:14
Fixes the following W=1 kernel build warning(s):
drivers/hid/usbhid/usbkbd.c:66: warning: bad line: should be on
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <redacted>
Cc: message to <redacted>
Cc: linux-usb@vger.kernel.org
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/hid/usbhid/usbkbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Lee Jones <hidden> Date: 2021-03-24 17:35:15
Fixes the following W=1 kernel build warning(s):
drivers/hid/intel-ish-hid/ishtp/bus.c:173: warning: Function parameter or member 'fw_client' not described in 'ishtp_get_fw_client_id'
drivers/hid/intel-ish-hid/ishtp/bus.c:845: warning: Function parameter or member 'device' not described in 'ishtp_device'
drivers/hid/intel-ish-hid/ishtp/bus.c:858: warning: Function parameter or member 'device' not described in 'ishtp_get_pci_device'
drivers/hid/intel-ish-hid/ishtp/bus.c:871: warning: Function parameter or member 'cl_device' not described in 'ishtp_trace_callback'
drivers/hid/intel-ish-hid/ishtp/bus.c:884: warning: Function parameter or member 'dev' not described in 'ish_hw_reset'
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <redacted>
Cc: "Uwe Kleine-König" <redacted>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/hid/intel-ish-hid/ishtp/bus.c | 5 +++++
1 file changed, 5 insertions(+)
From: Lee Jones <hidden> Date: 2021-03-24 17:35:15
Fixes the following W=1 kernel build warning(s):
drivers/hid/hid-logitech-hidpp.c:275: warning: Function parameter or member 'hidpp' not described in 'hidpp_send_message_sync'
drivers/hid/hid-logitech-hidpp.c:275: warning: Function parameter or member 'message' not described in 'hidpp_send_message_sync'
drivers/hid/hid-logitech-hidpp.c:275: warning: Function parameter or member 'response' not described in 'hidpp_send_message_sync'
drivers/hid/hid-logitech-hidpp.c:275: warning: expecting prototype for and something else(). Prototype was for hidpp_send_message_sync() instead
drivers/hid/hid-logitech-hidpp.c:427: warning: wrong kernel-doc identifier on line:
drivers/hid/hid-logitech-hidpp.c:470: warning: Function parameter or member 'input_dev' not described in 'hidpp_scroll_counter_handle_scroll'
drivers/hid/hid-logitech-hidpp.c:1894: warning: Function parameter or member 'hidpp' not described in 'hidpp_touchpad_fw_items_set'
drivers/hid/hid-logitech-hidpp.c:1894: warning: Function parameter or member 'feature_index' not described in 'hidpp_touchpad_fw_items_set'
drivers/hid/hid-logitech-hidpp.c:1894: warning: Function parameter or member 'items' not described in 'hidpp_touchpad_fw_items_set'
drivers/hid/hid-logitech-hidpp.c:1894: warning: expecting prototype for send a set state command to the device by reading the current items(). Prototype was for hidpp_touchpad_fw_items_set() instead
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <redacted>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Lopez Casado <redacted>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/hid/hid-logitech-hidpp.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
From: Lee Jones <hidden> Date: 2021-03-24 17:35:41
Fixes the following W=1 kernel build warning(s):
In file included from drivers/hid/intel-ish-hid/ishtp-hid.c:11:
drivers/hid/intel-ish-hid/ishtp-hid.c:263: warning: expecting prototype for ishtp_hid_probe(). Prototype was for ishtp_hid_remove() instead
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <redacted>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -254,7 +254,7 @@ int ishtp_hid_probe(unsigned int cur_hid_dev,}/**-*ishtp_hid_probe()-Removeregisteredhiddevice+*ishtp_hid_remove()-Removeregisteredhiddevice*@client_data:clientdatapointer**ThisfunctionisusedtodestroyallocatdHIDdevice.
From: Lee Jones <hidden> Date: 2021-03-24 17:35:41
Fixes the following W=1 kernel build warning(s):
drivers/hid/hid-thrustmaster.c:23: warning: Incorrect use of kernel-doc format: * These interrupts are used to prevent a nasty crash when initializing the
drivers/hid/hid-thrustmaster.c:26: warning: cannot understand function prototype: 'const u8 setup_0[] = '
drivers/hid/hid-thrustmaster.c:49: warning: cannot understand function prototype: 'struct tm_wheel_info '
drivers/hid/hid-thrustmaster.c:62: warning: wrong kernel-doc identifier on line:
drivers/hid/hid-thrustmaster.c:84: warning: cannot understand function prototype: 'struct __packed tm_wheel_response '
drivers/hid/hid-thrustmaster.c:143: warning: wrong kernel-doc identifier on line:
drivers/hid/hid-thrustmaster.c:202: warning: Function parameter or member 'urb' not described in 'thrustmaster_model_handler'
drivers/hid/hid-thrustmaster.c:202: warning: expecting prototype for Called by the USB subsystem when the wheel responses to our request(). Prototype was for thrustmaster_model_handler() instead
drivers/hid/hid-thrustmaster.c:265: warning: wrong kernel-doc identifier on line:
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <redacted>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Dario Pagani <redacted>
Cc: Kim Kuparinen <redacted>
Cc: linux-input@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <redacted>
---
drivers/hid/hid-thrustmaster.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
@@ -122,7 +122,7 @@ struct tm_wheel {structusb_ctrlrequest*change_request;};-/** The control packet to send to wheel */+/* The control packet to send to wheel */staticconststructusb_ctrlrequestmodel_request={.bRequestType=0xc1,.bRequest=73,
@@ -191,7 +191,7 @@ static void thrustmaster_change_handler(struct urb *urb)hid_warn(hdev,"URB to change wheel mode seems to have failed with error %d\n",urb->status);}-/**+/**CalledbytheUSBsubsystemwhenthewheelresponsestoourrequest*toget[whatitseemstobe]thewheel'smodel.*
From: Lee Jones <hidden> Date: 2021-03-24 17:35:41
Fixes the following W=1 kernel build warning(s):
drivers/hid/hid-picolcd_core.c: In function ‘picolcd_raw_event’:
drivers/hid/hid-picolcd_core.c:332:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <redacted>
Cc: "L. Vinyard, Jr" <redacted>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <redacted>
---
drivers/hid/hid-picolcd_core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
From: Jonathan Cameron <jic23@kernel.org> Date: 2021-03-26 11:42:47
On Wed, 24 Mar 2021 17:33:39 +0000
Lee Jones [off-list ref] wrote:
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee, it's a bit novel to cc linux-iio on the cover letter but
none of the actual patches.. Or least none of them reached
me or lore.kernel.org
I'm sure they are great :)
Jonathan
Lee Jones (25):
HID: intel-ish-hid: Remove unused variable 'err'
HID: ishtp-hid-client: Move variable to where it's actually used
HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
HID: intel-ish: Supply some missing param descriptions
HID: intel-ish: Fix a naming disparity and a formatting error
HID: usbhid: Repair a formatting issue in a struct description
HID: intel-ish-hid: Fix a little doc-rot
HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
HID: hid-alps: Correct struct misnaming
HID: intel-ish-hid: Fix potential copy/paste error
HID: hid-core: Fix incorrect function name in header
HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
header
HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
HID: hid-picolcd_core: Remove unused variable 'ret'
HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
abuses
HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
HID: hid-uclogic-params: Ensure function names are present and correct
in kernel-doc headers
HID: hid-sensor-custom: Remove unused variable 'ret'
HID: wacom_sys: Demote kernel-doc abuse
HID: hid-sensor-hub: Remove unused struct member 'quirks'
HID: hid-sensor-hub: Move 'hsdev' description to correct struct
definition
HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
drivers/hid/hid-alps.c | 2 +-
drivers/hid/hid-core.c | 2 +-
drivers/hid/hid-kye.c | 2 +-
drivers/hid/hid-logitech-hidpp.c | 7 +--
drivers/hid/hid-picolcd_core.c | 5 +--
drivers/hid/hid-sensor-custom.c | 5 +--
drivers/hid/hid-sensor-hub.c | 4 +-
drivers/hid/hid-thrustmaster.c | 24 +++++------
drivers/hid/hid-uclogic-params.c | 8 ++--
drivers/hid/hid-uclogic-rdesc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-
drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++----------
drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +---
drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++-
drivers/hid/intel-ish-hid/ishtp/client.c | 5 +--
drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +-
drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +-
drivers/hid/usbhid/hid-pidff.c | 4 +-
drivers/hid/usbhid/usbkbd.c | 2 +-
drivers/hid/wacom_sys.c | 2 +-
include/linux/intel-ish-client-if.h | 8 +++-
24 files changed, 90 insertions(+), 81 deletions(-)
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Anssi Hannula <redacted>
Cc: Benjamin Tissoires <redacted>
Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Drubin <redacted>
Cc: Dario Pagani <redacted>
Cc: dri-devel@lists.freedesktop.org
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Kai-Heng Feng <redacted>
Cc: Kim Kuparinen <redacted>
Cc: "Krzysztof Wilczyński" <redacted>
Cc: Lee Jones <redacted>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-iio@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-usb@vger.kernel.org
Cc: Lopez Casado <redacted>
Cc: "L. Vinyard, Jr" <redacted>
Cc: Masaki Ota <redacted>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: message to <redacted>
Cc: Michael Haboustak <redacted>
Cc: Rushikesh S Kadam <redacted>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Uwe Kleine-König" <redacted>
Cc: Vojtech Pavlik <redacted>
Cc: Zhang Lixu <lixu.zhang@intel.com>
From: Lee Jones <hidden> Date: 2021-03-26 14:21:24
On Fri, 26 Mar 2021, Jonathan Cameron wrote:
On Wed, 24 Mar 2021 17:33:39 +0000
Lee Jones [off-list ref] wrote:
quoted
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee, it's a bit novel to cc linux-iio on the cover letter but
none of the actual patches.. Or least none of them reached
me or lore.kernel.org
Looks like only 18 of the 25 actually made it onto the list.
How odd!
Hold on, I'll submit a [RESEND].
I'm sure they are great :)
Naturally!
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog