Re: [PATCH v3 6/9] Input: wacom_i2c - Clean up the query device fields

On Sun, Mar 21, 2021 at 10:10:46AM -0400, Alistair Francis wrote:

Improve the query device fields to be more verbose.

Signed-off-by: Alistair Francis <redacted>
---
 drivers/input/touchscreen/wacom_i2c.c | 71 +++++++++++++++++++--------

...

 
+	rstc = devm_reset_control_get_optional_exclusive(&client->dev, NULL);
+	if (IS_ERR(rstc))
+		dev_err(&client->dev, "Failed to get reset control before init\n");
+	else
+		reset_control_reset(rstc);

This seems misplaced. Also, reset controls are typically for resetting
the system, for resetting peripherals we expose reset GPIO lines.

Thanks.

-- 
Dmitry