[PATCH] Input: i8042: Add ASUS Zenbook Flip to noselftest list

Subsystems: input (keyboard, mouse, joystick, touchscreen) drivers, the rest

STALE1994d LANDED

Landed in mainline as b5d6e7ab7fe7 on 2021-02-19.

2 messages, 2 authors, 2021-02-19 · open the first message on its own page

[PATCH] Input: i8042: Add ASUS Zenbook Flip to noselftest list

From: Marcos Paulo de Souza <hidden>
Date: 2021-02-19 16:48:38

After commit 77b425399f6d ("Input: i8042 - use chassis info to skip
selftest on Asus laptops"), all modern Asus laptops have the i8042
selftest disabled. It has done by using chassys type "10" (laptop).

The Asus Zenbook Flip suffers from similar suspend/resume issues, but
it _sometimes_ work and sometimes it doesn't. Setting noselftest makes
it work reliably. In this case, we need to add chassis type "31"
(convertible) in order to avoid selftest in this device.

#Reported-by: Ludvig Norgren Guldhag [off-list ref]
Signed-off-by: Marcos Paulo de Souza <redacted>
---

 Dmitry, it seems that other laptops also report chassis type == 31 for
 convertible, like some HPs and other Asus convertible models. What do you
 think about it?

 drivers/input/serio/i8042-x86ia64io.h | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
index c74b020796a9..9119e12a5778 100644
--- a/drivers/input/serio/i8042-x86ia64io.h
+++ b/drivers/input/serio/i8042-x86ia64io.h
@@ -588,6 +588,10 @@ static const struct dmi_system_id i8042_dmi_noselftest_table[] = {
 			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
 			DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /* Notebook */
 		},
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /* Convertible Notebook */
+		},
 	},
 	{ }
 };
-- 
2.26.2

Re: [PATCH] Input: i8042: Add ASUS Zenbook Flip to noselftest list

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2021-02-19 18:38:33

On Fri, Feb 19, 2021 at 01:46:38PM -0300, Marcos Paulo de Souza wrote:
After commit 77b425399f6d ("Input: i8042 - use chassis info to skip
selftest on Asus laptops"), all modern Asus laptops have the i8042
selftest disabled. It has done by using chassys type "10" (laptop).

The Asus Zenbook Flip suffers from similar suspend/resume issues, but
it _sometimes_ work and sometimes it doesn't. Setting noselftest makes
it work reliably. In this case, we need to add chassis type "31"
(convertible) in order to avoid selftest in this device.

#Reported-by: Ludvig Norgren Guldhag [off-list ref]
Signed-off-by: Marcos Paulo de Souza <redacted>
Applied, thank you.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help