Re: [PATCH v2 3/5] dt-bindings: input: touchscreen: Move helper bindings to core
From: Jeff LaBundy <hidden>
Date: 2021-02-10 03:13:45
Also in:
linux-devicetree
Hi Rob, Thank you for taking a look at the series. On Tue, Feb 09, 2021 at 10:27:40AM -0600, Rob Herring wrote:
On Sat, Jan 23, 2021 at 09:42:54PM -0600, Jeff LaBundy wrote:quoted
With the helper functions moving to /drivers/input/ following the discussion in [1], touchscreen.yaml and touchscreen.txt are moved one level up as well to maintain a consistent directory structure. No changes are made to either file except to update the $id field in touchscreen.yaml to reflect the new path. The handful of .yaml bindings that reference the original relative path are updated as well. Last but not least, the handful of .txt bindings that included an absolute path to touchscreen.txt are updated too. [1] https://patchwork.kernel.org/patch/11924029/ Signed-off-by: Jeff LaBundy <redacted> --- Changes in v2: - Added this patch to the series .../devicetree/bindings/input/elan_i2c.txt | 2 +- .../devicetree/bindings/input/touchscreen.txt | 1 + .../devicetree/bindings/input/touchscreen.yaml | 83 ++++++++++++++++++++++ .../bindings/input/touchscreen/ads7846.txt | 2 +- .../bindings/input/touchscreen/bu21013.txt | 2 +- .../input/touchscreen/cypress,cy8ctma140.yaml | 2 +- .../bindings/input/touchscreen/edt-ft5x06.yaml | 2 +- .../bindings/input/touchscreen/eeti,exc3000.yaml | 2 +- .../input/touchscreen/elan,elants_i2c.yaml | 2 +- .../bindings/input/touchscreen/goodix.yaml | 2 +- .../bindings/input/touchscreen/iqs5xx.txt | 2 +- .../bindings/input/touchscreen/mms114.txt | 2 +- .../bindings/input/touchscreen/touchscreen.txt | 1 - .../bindings/input/touchscreen/touchscreen.yaml | 83 ---------------------- 14 files changed, 94 insertions(+), 94 deletions(-) create mode 100644 Documentation/devicetree/bindings/input/touchscreen.txt create mode 100644 Documentation/devicetree/bindings/input/touchscreen.yaml delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/touchscreen.yamlNo, I prefer the current structure. It's easier to find similar types of h/w as-is. In fact, if you wanted to move keyboards/keypads to their own subdir, I'd welcome that.
No problem, I will drop this patch from the series and update the $ref in patch [4/5] to reference the original touchscreen.yaml.
Rob
Kind regards, Jeff LaBundy