Re: [PATCH] Input: Use true and false for bool variable
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2021-02-19 03:35:25
Also in:
lkml
Hi, On Thu, Feb 18, 2021 at 06:23:55PM +0800, Jiapeng Chong wrote:
quoted hunk ↗ jump to hunk
Fix the following coccicheck warnings: ./drivers/input/touchscreen/zinitix.c:250:8-9: WARNING: return of 0/1 in function 'zinitix_init_touch' with return type bool. Reported-by: Abaci Robot <redacted> Signed-off-by: Jiapeng Chong <redacted> --- drivers/input/touchscreen/zinitix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/input/touchscreen/zinitix.c b/drivers/input/touchscreen/zinitix.c index a3e3adb..acb1d53 100644 --- a/drivers/input/touchscreen/zinitix.c +++ b/drivers/input/touchscreen/zinitix.c@@ -247,7 +247,7 @@ static bool zinitix_init_touch(struct bt541_ts_data *bt541) udelay(10); } - return 0; + return false;
This is incorrect, as earlier we try to return error codes from this function. It needs to be changed to return int, I'll take care of it. Thanks. -- Dmitry