Re: [PATCH 1/3] Input: applespi: Don't wait for responses to commands indefinitely.

[PATCH 1/3] Input: applespi: Don't wait for responses to commands indefinitely. · Ronald Tschalär <hidden> · 2021-02-17
[PATCH 3/3] Input: applespi: Add trace_event module param for early tracing. · Ronald Tschalär <hidden> · 2021-02-17
Re: [PATCH 3/3] Input: applespi: Add trace_event module param for early tracing. · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2021-02-17
Re: [PATCH 3/3] Input: applespi: Add trace_event module param for early tracing. · Life is hard, and then you die <hidden> · 2021-02-17
Re: [PATCH 3/3] Input: applespi: Add trace_event module param for early tracing. · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2021-02-17
Re: [PATCH 3/3] Input: applespi: Add trace_event module param for early tracing. · Life is hard, and then you die <hidden> · 2021-02-17
Re: [PATCH 3/3] Input: applespi: Add trace_event module param for early tracing. · kernel test robot <hidden> · 2021-02-18
Re: [PATCH 3/3] Input: applespi: Add trace_event module param for early tracing. · kernel test robot <hidden> · 2021-02-18
[PATCH 2/3] Input: applespi: Fix occasional crc errors under load. · Ronald Tschalär <hidden> · 2021-02-17
Re: [PATCH 2/3] Input: applespi: Fix occasional crc errors under load. · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2021-02-19
Re: [PATCH 1/3] Input: applespi: Don't wait for responses to commands indefinitely. · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2021-02-17
Re: [PATCH 1/3] Input: applespi: Don't wait for responses to commands indefinitely. · Life is hard, and then you die <hidden> · 2021-02-17
Re: [PATCH 1/3] Input: applespi: Don't wait for responses to commands indefinitely. · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2021-02-19

From: Life is hard, and then you die <hidden>
Date: 2021-02-17 20:52:49
Also in: lkml

  Hi Dmitry,

On Wed, Feb 17, 2021 at 12:23:23PM -0800, Dmitry Torokhov wrote:

On Wed, Feb 17, 2021 at 11:07:16AM -0800, Ronald Tschalär wrote:

quoted

@@ -869,7 +878,7 @@ static int applespi_send_cmd_msg(struct applespi_data *applespi)
 		return sts;
 	}
 
-	applespi->cmd_msg_queued = true;
+	applespi->cmd_msg_queued = ktime_get();

Will it be OK if I change this to ktime_get_coarse()? I do not think we
need exact time here, and the coarse variant is cheaper I believe.

Certainly - I just wasn't aware of the coarse variant.


  Cheers,

  Ronald

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help