Re: [PATCH] Input: cros_ec_keyb: Add support for a front proximity switch

Quoting Guenter Roeck (2021-01-06 18:30:20)

On Wed, Jan 6, 2021 at 5:16 PM Doug Anderson [off-list ref] wrote:

    Hi,

    On Fri, Dec 4, 2020 at 4:48 PM Stephen Boyd [off-list ref] wrote:
    >
    > Some cros ECs support a front proximity MKBP event via
    > 'EC_MKBP_FRONT_PROXIMITY'. Map this to the 'SW_FRONT_PROXIMITY' input
    > event code so it can be reported up to userspace.
    >
    > Cc: Dmitry Torokhov [off-list ref]
    > Cc: Benson Leung [off-list ref]
    > Cc: Guenter Roeck [off-list ref]
    > Signed-off-by: Stephen Boyd [off-list ref]
    > ---
    >  drivers/input/keyboard/cros_ec_keyb.c          | 5 +++++
    >  include/linux/platform_data/cros_ec_commands.h | 1 +


For a year or two people kept changes to cros_ec_commands.h separate from
functional changes. Unfortunately, we are now reverting to the old
"change cros_ec_commands.h together with some functional change" approach which
caused an endless amount of trouble and pain for Chrome OS rebases a couple of
years ago.

I won't NACK this patch, but it is close.

I'm fine to split it into two, or keep it together. Just let me know
what is preferred. Thanks!