Thread (5 messages) 5 messages, 3 authors, 2021-01-12

Re: [PATCH] input: ariel-pwrbutton.c: Remove unused variable ariel_pwrbutton_id_table[]

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2021-01-12 03:45:03
Also in: lkml

On Tue, Jan 12, 2021 at 04:20:28AM +0100, Lubomir Rintel wrote:
On Mon, Jan 04, 2021 at 02:02:13PM -0800, Dmitry Torokhov wrote:
quoted
On Tue, Dec 29, 2020 at 01:15:10PM +0530, Souptick Joarder wrote:
quoted
On Tue, Dec 22, 2020 at 1:34 AM Souptick Joarder [off-list ref] wrote:
quoted
Kernel test robot throws below warning ->
quoted
quoted
drivers/input/misc/ariel-pwrbutton.c:152:35: warning: unused variable
'ariel_pwrbutton_id_table' [-Wunused-const-variable]
   static const struct spi_device_id ariel_pwrbutton_id_table[] = {
                                     ^
   1 warning generated.

Remove unused variable ariel_pwrbutton_id_table[] if no plan to use
it further.

Reported-by: kernel test robot <redacted>
Signed-off-by: Souptick Joarder <redacted>
Any comment on this patch ?
Lubomir, would you prefer to remove the table or add it to the driver
structure as ariel_pwrbutton_driver->id_table?
I believe it can be safely dropped, as the OF match seems to be
sufficient.

Thank you for the patch Souptick.

Reviewed-by: Lubomir Rintel <lkundrak@v3.sk>
Applied, thank you.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help