Re: [PATCH v7 1/4] HID: i2c-hid: Reorganize so ACPI and OF are separate modules

Hi,

On Fri, Dec 11, 2020 at 11:25 AM kernel test robot [off-list ref] wrote:

Hi Douglas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on hid/for-next]
[also build test WARNING on next-20201211]
[cannot apply to jikos-trivial/for-next v5.10-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Douglas-Anderson/HID-i2c-hid-Reorganize-to-allow-supporting-goodix-gt7375p/20201212-014239
base:   https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5a371169c8cc2abb463e32db3a3fe60ea34efc87
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Douglas-Anderson/HID-i2c-hid-Reorganize-to-allow-supporting-goodix-gt7375p/20201212-014239
        git checkout 5a371169c8cc2abb463e32db3a3fe60ea34efc87
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All warnings (new ones prefixed by >>):

quoted

quoted

drivers/hid/i2c-hid/i2c-hid-core.c:1050:5: warning: no previous prototype for 'i2c_hid_core_suspend' [-Wmissing-prototypes]

    1050 | int i2c_hid_core_suspend(struct device *dev)
         |     ^~~~~~~~~~~~~~~~~~~~

quoted

quoted

drivers/hid/i2c-hid/i2c-hid-core.c:1084:5: warning: no previous prototype for 'i2c_hid_core_resume' [-Wmissing-prototypes]

    1084 | int i2c_hid_core_resume(struct device *dev)
         |     ^~~~~~~~~~~~~~~~~~~

Yup, that's definitely true.  At the risk of a little extra spam, I'll
spin a quick v8 making these static so it's ready to land.  I guess I
missed doing that when we stopped exporting them and my compiler
doesn't yell about this.

-Doug