Thread (5 messages) 5 messages, 4 authors, 2020-12-10

Re: [PATCH] Input: edt-ft5x06 - consolidate handling of number of electrodes

flat view

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2020-12-10 11:34:56
Also in: lkml

On Thu, Dec 10, 2020 at 11:08:03AM +0100, Marco Felsch wrote:
On 20-12-09 15:09, Dmitry Torokhov wrote:
...
quoted
 	case EV_FT:
 		reg_addr->reg_threshold = EV_REGISTER_THRESHOLD;
+		reg_addr->reg_report_rate = NO_REGISTER;
 		reg_addr->reg_gain = EV_REGISTER_GAIN;
 		reg_addr->reg_offset = NO_REGISTER;
 		reg_addr->reg_offset_x = EV_REGISTER_OFFSET_X;
 		reg_addr->reg_offset_y = EV_REGISTER_OFFSET_Y;
 		reg_addr->reg_num_x = NO_REGISTER;
 		reg_addr->reg_num_y = NO_REGISTER;
-		reg_addr->reg_report_rate = NO_REGISTER;
 		break;
Nit:
Unrelated change.
I guess the motive is to get these assignments consistent between the cases.
Documentation actually allows this kind of modifications of code in one change
when them are toughly related.

-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help