Re: [PATCH v3 6/7] input: atc260x: Add onkey driver for ATC260x PMICs
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2020-12-06 04:11:24
Also in:
linux-devicetree, linux-pm, lkml
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2020-12-06 04:11:24
Also in:
linux-devicetree, linux-pm, lkml
On Sun, Dec 06, 2020 at 03:27:06AM +0200, Cristian Ciocaltea wrote:
The Actions Semi ATC260x PMICs are able to manage an onkey button.
This driver exposes the ATC260x onkey as an input device. It can also
be configured to force a system reset on a long key-press with an
adjustable duration.
The currently supported chip variants are ATC2603C and ATC2609A.
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
---
Changes in v3:
- Integrated Dmitry's review:
* Dropped the logic around the check for 'pdev->dev.of_node'
* Renamed 'ret' variable in 'atc260x_onkey_probe()' to 'error'
* Used 'dev_dbg' instead of 'dev_info' on status KEY_RESET_DISABLED
* Dropped 'input_dev->evbit[0] = BIT_MASK(EV_KEY);'
* Removed IRQF_TRIGGER_HIGH flag on 'devm_request_threaded_irq()'
* Implemented open/close to mitigate the racing issue in
'atc260x_onkey_remove()' which has been dropped now
- Removed the unnecessary driver compatibles
- Used 'reset-time-sec' property of the parent device instead of
'actions,reset-time-sec' of now obsolete and removed 'onkey' DT nodeAcked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Please merge with the rest through MFD I suppose. Thanks. -- Dmitry