On 11/23/2020 10:38 AM, Nicolas Saenz Julienne wrote:

When unbinding the firmware device we need to make sure it has no
consumers left. Otherwise we'd leave them with a firmware handle
pointing at freed memory.

Keep a reference count of all consumers and introduce rpi_firmware_put()
which will permit automatically decrease the reference count upon
unbinding consumer drivers.

Suggested-by: Uwe Kleine-König <redacted>
Signed-off-by: Nicolas Saenz Julienne <redacted>

This looks fine to me, just one nit below:

[snip]

 /**
- * rpi_firmware_get - Get pointer to rpi_firmware structure.

Is not removing this line going to create a kernel doc warning?

With that fixed:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian