Thread (5 messages) 5 messages, 2 authors, 2020-11-25

Re: [PATCH 0/3] HID: sony: various DS4 improvements

From: Jiri Kosina <jikos@kernel.org>
Date: 2020-11-25 12:55:24

On Mon, 9 Nov 2020, Roderick Colenbrander wrote:
From: Roderick Colenbrander <roderick.colenbrander@sony.com>

Hi,

This patch series provides a number of independent DS4 driver
improvements.

The first patch improves DS4 battery level and battery status
reporting. The current implementation interpreted the value
ranges and status levels incorrectly.

The second patch fixes a DS4 dongle kernel crash (bug 206785).
The specific problem is related to Steam, which implements
its own user-space DS4 driver using hidraw. It collides during
DS4 dongle hotplug, causing 'out of order HID feature reports'.
The driver didn't expect this and this led to a kernel crash
later on due to interpreting data incorrectly. The workaround
is checking if the right data was returned and retrying.
Though, I really really dislike this type of fix. Long-term
some solution is needed to perhaps prevent hidraw and evdev
drivers to step on each other's toes. For now this fixes
the current problem.

The last patch fixes sysfs cleanup issues encountered using
the DS4 dongle.
Hi Roderick,

I've applied the kernel crash fix to for-5.10/upstream-fixes and remaining 
two to for-5.11/sony.

Thanks,

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help