Thread (72 messages) 72 messages, 22 authors, 2020-12-08

Re: [PATCH 000/141] Fix fall-through warnings for Clang

From: Andy Shevchenko <hidden>
Date: 2020-11-25 10:37:35
Also in: amd-gfx, bridge, ceph-devel, dm-devel, dri-devel, intel-gfx, intel-wired-lan, keyrings, linux-acpi, linux-arm-msm, linux-block, linux-can, linux-cifs, linux-crypto, linux-ext4, linux-fbdev, linux-gpio, linux-hardening, linux-hwmon, linux-ide, linux-iio, linux-integrity, linux-media, linux-mediatek, linux-mm, linux-mmc, linux-nfs, linux-rdma, linux-renesas-soc, linux-scsi, linux-sctp, linux-security-module, linux-usb, linux-watchdog, linux-wireless, lkml, netdev, netfilter-devel, op-tee, selinux, target-devel, virtualization, xen-devel

On Mon, Nov 23, 2020 at 10:39 PM James Bottomley
[off-list ref] wrote:
On Mon, 2020-11-23 at 19:56 +0100, Miguel Ojeda wrote:
quoted
On Mon, Nov 23, 2020 at 4:58 PM James Bottomley
[off-list ref] wrote:
...
quoted
But if we do the math, for an author, at even 1 minute per line
change and assuming nothing can be automated at all, it would take 1
month of work. For maintainers, a couple of trivial lines is noise
compared to many other patches.
So you think a one line patch should take one minute to produce ... I
really don't think that's grounded in reality.  I suppose a one line
patch only takes a minute to merge with b4 if no-one reviews or tests
it, but that's not really desirable.
In my practice most of the one line patches were either to fix or to
introduce quite interesting issues.
1 minute is 2-3 orders less than usually needed for such patches.
That's why I don't like churn produced by people who often even didn't
compile their useful contributions.

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help