-----Original Message-----
From: Ardelean, Alexandru
Sent: Thursday, November 12, 2020 8:40 AM
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: RE: [PATCH 1/6] Input: adp5589: use a single variable for error in probe

quoted

-----Original Message-----
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Sent: Thursday, November 12, 2020 2:38 AM
To: Ardelean, Alexandru <redacted>
Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] Input: adp5589: use a single variable for
error in probe

[External]

Hi Alexandru,

On Wed, Nov 11, 2020 at 10:48:28AM +0200, Alexandru Ardelean wrote:

quoted

The 'error' & 'ret' variables are used. This is a bit of duplication.
This change replaces the use of error with the 'ret' variable since
the name is a bit more generic.

I really prefer variables that carry error codes/success and are used
in error paths to be called "error", and "ret" or "retval" to be used
in cases where we may return actual data.

Ack.
Will do it the other way around for v2.

Wait.
I just had some coffee.
I think you're saying to drop this patch.
Also fine from my side.

quoted

Thanks.

--
Dmitry