On Thu, 05 Nov 2020, Joe Perches wrote:

On Thu, 2020-11-05 at 23:26 -0800, Dmitry Torokhov wrote:

quoted

On Wed, Nov 04, 2020 at 04:24:17PM +0000, Lee Jones wrote:

quoted

Fixes the following W=1 kernel build warning(s):

 drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’:
 drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]

[]

quoted

quoted

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c

[]

quoted

quoted

@@ -1106,8 +1106,9 @@ static void synaptics_process_packet(struct psmouse *psmouse)

 					num_fingers = hw.w + 2;
 				break;
 			case 2:
-				if (SYN_MODEL_PEN(info->model_id))
+				if (SYN_MODEL_PEN(info->model_id)) {
 					;   /* Nothing, treat a pen as a single finger */
+				}

This gives me:

WARNING: braces {} are not necessary for single statement blocks

from checkpatch.

As the entire case 2 is effectively a noop, why not just comment it better
and remove the if (SYN_MODEL_PEN(...)) test altogether.

Happy to do that if that's okay with Dmitry.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog