Thread (10 messages) 10 messages, 3 authors, 2020-10-19

Re: [PATCH V8] HID: ASUS: Add support for ASUS N-Key keyboard

From: Luke Jones <luke@ljones.dev>
Date: 2020-10-18 21:37:05

quoted
 +               */
 +               if (report->id == FEATURE_KBD_LED_REPORT_ID1 ||
 +                               report->id == 
FEATURE_KBD_LED_REPORT_ID2) {
quoted
 +                       return -1;
is -1 a good return code? (this Q for all cases)
quoted
 +               /* Additional report filtering */
 +               } else if (report->id == FEATURE_KBD_REPORT_ID) {
 +                       /* Fn+F5 "fan" symbol, trigger WMI event to 
toggle next mode */
 +                       if (data[1] == 0xae) {
 +                               ret = asus_wmi_send_event(drvdata, 
0xae);
 +                               if (ret < 0) {
 +                                       hid_warn(hdev, "Asus failed 
to trigger fan control event");
 +                               }
quoted
 +                               return -1;
In the case of this block I really don't have any idea how
to handle it. I want to stop these particular keycodes from
being evaluated elsewhere. Returning -1 seemed to be the only
way to do this, unless my understanding is very incorrect.

Any help or guidance on how to handle this is definitely
appreciated.

Cheers,
Luke.


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help