Re: [PATCH v2 4/4] Input: sun4i-ps2 - Fix handling of platform_get_irq() error
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2020-09-16 01:01:49
Also in:
linux-arm-kernel, lkml
On Fri, Aug 28, 2020 at 04:57:44PM +0200, Krzysztof Kozlowski wrote:
quoted hunk ↗ jump to hunk
platform_get_irq() returns -ERRNO on error. In such case comparison to 0 would pass the check. Fixes: e443631d20f5 ("Input: serio - add support for Alwinner A10/A20 PS/2 controller") Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Changes since v1: 1. None --- drivers/input/serio/sun4i-ps2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)diff --git a/drivers/input/serio/sun4i-ps2.c b/drivers/input/serio/sun4i-ps2.c index a681a2c04e39..7da1ea8741fc 100644 --- a/drivers/input/serio/sun4i-ps2.c +++ b/drivers/input/serio/sun4i-ps2.c@@ -265,9 +265,8 @@ static int sun4i_ps2_probe(struct platform_device *pdev) /* Get IRQ for the device */ irq = platform_get_irq(pdev, 0); - if (!irq) { - dev_err(dev, "no IRQ found\n"); - error = -ENXIO; + if (irq < 0) {
"irq" is unsigned here, so this will not work. I'll change it to use drvdat->irq which happens to be signed, and drop "irq" variable.
+ error = irq; goto err_disable_clk; } -- 2.17.1
Thanks. -- Dmitry