Re: [PATCH] HID: core: Correctly handle ReportSize being zero
From: Benjamin Tissoires <hidden>
Date: 2020-09-01 09:34:55
Also in:
lkml, stable
From: Benjamin Tissoires <hidden>
Date: 2020-09-01 09:34:55
Also in:
lkml, stable
On Tue, Sep 1, 2020 at 10:14 AM Jiri Kosina [off-list ref] wrote:
On Sat, 29 Aug 2020, Marc Zyngier wrote:quoted
It appears that a ReportSize value of zero is legal, even if a bit non-sensical. Most of the HID code seems to handle that gracefully, except when computing the total size in bytes. When fed as input to memset, this leads to some funky outcomes. Detect the corner case and correctly compute the size. Cc: stable@vger.kernel.org Signed-off-by: Marc Zyngier <maz@kernel.org>Thanks Marc; Benjamin will be pushing this patch through his regression testing machinery, and if all is good, I'll push it for 5.9-rc still.
Test results were good. I have now pushed this patch to for-5.9/upstream-fixes Cheers, Benjamin
-- Jiri Kosina SUSE Labs