Re: [PATCH] HID: asus: Add support for N-Key keyboard 0x1866

From
Jiri Kosina <jikos@kernel.org>
Date
2020-08-17 10:04:39
Reply to
Luke Jones, 2020-07-30
On Thu, 30 Jul 2020, Luke Jones wrote:
Enable missing functionality of the keyboard found in many ASUS
Zephyrus laptops: Fn key combos and hotkeys, keyboard backlight
brightness control. Two input event codes are added for keyboard
LED mode switching prev/next.

The keyboard has many of the same key outputs as the existing G752
keyboard including a few extras, and varies a little between laptop
models.

Additionally the keyboard requires the LED interface to be
intitialised before such things as keyboard backlight control work.

Misc changes in scope: update some hardcoded comparisons to use an
available define, change "Mic Toggle" to use a keycode that works.

Signed-off-by: Luke D Jones <luke@ljones.dev>
Luke,

thanks for the patch.

Unfortunately it has been completely whitespace-damaged by your mail 
client, so it can't be properly applied / reviewed. Could you please 
adjust your setup and resend?

Thanks,

-- 
Jiri Kosina
SUSE Labs
Thread (2 messages) 2 messages, 2 authors, last reply 2020-08-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help