Re: [PATCH v17 1/3] dt-bindings: Add bindings for Mediatek matrix keypad
From: Yingjoe Chen <hidden>
Date: 2020-08-11 01:48:27
Also in:
linux-arm-kernel, linux-devicetree, linux-mediatek, lkml
Hi, On Mon, 2020-08-10 at 14:40 +0800, Fengping Yu wrote:
quoted hunk
From: "fengping.yu" <redacted> This patch add devicetree bindings for Mediatek matrix keypad driver. Signed-off-by: fengping.yu <redacted> --- .../devicetree/bindings/input/mtk-kpd.yaml | 87 +++++++++++++++++++ 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.yamldiff --git a/Documentation/devicetree/bindings/input/mtk-kpd.yaml b/Documentation/devicetree/bindings/input/mtk-kpd.yaml new file mode 100644 index 000000000000..d74dd8a6fbde
<...>
+ keypad,num-columns: + description: Number of column lines connected to the keypad controller, + it is not equal to PCB columns number, instead you should add required value + for each IC. If not specified, the default value is 1. + + keypad,num-rows: + description: Number of row lines connected to the keypad controller, it is + not equal to PCB rows number, instead you should add required value for each IC. + If not specified, the default value is 1.
Your source code can't really handle dts without rows/columns properties. Also, the default value doesn't make any sense. No IC will have rows or columns set to 1. Since these are IC specified, not board specified, I think you should just have the correct numbers in driver. Joe.C