Re: [PATCH v7 2/4] SFH: PCIe driver to add support of AMD sensor fusion hub
flat view
From: Randy Dunlap <rdunlap@infradead.org>
Date: 2020-08-10 23:03:40
Also in:
linux-iio, lkml
On 8/10/20 2:30 PM, Sandeep Singh wrote:
From: Sandeep Singh <redacted> AMD SFH uses HID over PCIe bus.SFH fw is part of MP2 processor (MP2 which is an ARM® Cortex-M4 core based co-processor to x86) and it runs on MP2 where in driver resides on X86. This part of module will communicate with MP2 Firmware and provide that data into DRAM Signed-off-by: Nehal Shah <redacted> Signed-off-by: Sandeep Singh <redacted> --- drivers/hid/Kconfig | 2 + drivers/hid/Makefile | 2 + drivers/hid/amd-sfh-hid/Kconfig | 21 ++++ drivers/hid/amd-sfh-hid/Makefile | 15 +++ drivers/hid/amd-sfh-hid/amd_mp2_pcie.c | 164 +++++++++++++++++++++++++ drivers/hid/amd-sfh-hid/amd_mp2_pcie.h | 83 +++++++++++++ 6 files changed, 287 insertions(+) create mode 100644 drivers/hid/amd-sfh-hid/Kconfig create mode 100644 drivers/hid/amd-sfh-hid/Makefile create mode 100644 drivers/hid/amd-sfh-hid/amd_mp2_pcie.c create mode 100644 drivers/hid/amd-sfh-hid/amd_mp2_pcie.h
Hi, Thanks for the update.
quoted hunk ↗ jump to hunk
diff --git a/drivers/hid/amd-sfh-hid/Kconfig b/drivers/hid/amd-sfh-hid/Kconfig new file mode 100644 index 000000000000..a042048e8dd4 --- /dev/null +++ b/drivers/hid/amd-sfh-hid/Kconfig@@ -0,0 +1,21 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +menu "AMD SFH HID support" + depends on X86_64 || COMPILE_TEST + depends on PCI + depends on HID + +config AMD_SFH_HID + tristate "AMD Sensor Fusion Hub" + help
Sorry I missed this in v6: help text should be indented with one tab + 2 spaces, so all of this should be indented an additional 2 spaces.
quoted hunk ↗ jump to hunk
+ If you say yes to this option, support will be included for the AMD + Sensor Fusion Hub. + This driver will enable sensors functionality to user through HID + framework. Basically this driver will get data from MP2 Firmware + and provide that data to HID framework. + MP2 which is an ARM® Cortex-M4 core based co-processor to x86. + + This driver can also be built as a module. If so, the module will + be called amd-sfhtp-hid. + Say Y or M here if you want to support AMD SFH. If unsure, say N. + +endmenu
-- ~Randy