Re: [PATCH v6 2/4] SFH: PCIe driver to add support of AMD sensor fusion
flat view
From: Randy Dunlap <rdunlap@infradead.org>
Date: 2020-08-09 13:59:30
Also in:
linux-iio, lkml
On 8/9/20 3:25 AM, Sandeep Singh wrote:
From: Sandeep Singh <redacted> AMD SFH uses HID over PCIe bus.SFH fw is part of MP2 processor (MP2 which is an ARM® Cortex-M4 core based co-processor to x86) and it runs on MP2 where in driver resides on X86. This part of module will communicate with MP2 FW and provide that data into DRAM Signed-off-by: Nehal Shah <redacted> Signed-off-by: Sandeep Singh <redacted> --- drivers/hid/Kconfig | 2 + drivers/hid/Makefile | 2 + drivers/hid/amd-sfh-hid/Kconfig | 21 ++++ drivers/hid/amd-sfh-hid/Makefile | 15 +++ drivers/hid/amd-sfh-hid/amd_mp2_pcie.c | 162 +++++++++++++++++++++++++ drivers/hid/amd-sfh-hid/amd_mp2_pcie.h | 83 +++++++++++++ 6 files changed, 285 insertions(+) create mode 100644 drivers/hid/amd-sfh-hid/Kconfig create mode 100644 drivers/hid/amd-sfh-hid/Makefile create mode 100644 drivers/hid/amd-sfh-hid/amd_mp2_pcie.c create mode 100644 drivers/hid/amd-sfh-hid/amd_mp2_pcie.h
Hi,
quoted hunk ↗ jump to hunk
diff --git a/drivers/hid/amd-sfh-hid/Kconfig b/drivers/hid/amd-sfh-hid/Kconfig new file mode 100644 index 000000000000..e73cf9fe1324 --- /dev/null +++ b/drivers/hid/amd-sfh-hid/Kconfig@@ -0,0 +1,21 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +menu "AMD SFH HID support" + depends on X86_64 || COMPILE_TEST + depends on PCI + +config AMD_SFH_HID + tristate "AMD Sensor Fusion Hub" + select HID
How about depends on HID We try hard not to select/enable entire subsystems just because one driver wants it. Also, HID depends on INPUT, so it's not safe to select HID unless INPUT is already enabled.
quoted hunk ↗ jump to hunk
+ help + If you say yes to this option, support will be included for the AMD + Sensor Fusion Hub. + This driver will enable sensors functionality to user through HID + framework. Basically this driver will get data from MP2 FW
s/FW/firmware/ or is it "framework" ?
quoted hunk ↗ jump to hunk
+ and provide that data to HID framework. + MP2 which is an ARM® Cortex-M4 core based co-processor to x86. + + This driver can also be built as modules. If so, the modules will
built as a module. If so, the module will
quoted hunk ↗ jump to hunk
+ be called amd-sfhtp-hid. + Say Y or M here if you want to support AMD SFH. If unsure, say N. + +endmenu
thanks. -- ~Randy