Re: [PATCH v3 3/3] Input: snvs_pwrkey - only IRQ_HANDLED for our own events

From
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date
2020-07-30 06:06:07
Also in
linux-crypto, linux-devicetree, lkml
Reply to
Marco Felsch, 2020-07-29
Hi Marco,

On Wed, Jul 29, 2020 at 09:55:13AM +0200, Marco Felsch wrote:
Hi,

On 20-07-23 10:43, Horia Geantă wrote:
quoted
From: André Draszik <redacted>

The snvs_pwrkey shares the SNVS LPSR status register with the snvs_rtc.

This driver here should only return IRQ_HANDLED if the status register
indicates that the event we're handling in the irq handler was genuinely
intended for this driver. Otheriwse the interrupt subsystem will
assume the interrupt was handled successfully even though it wasn't
at all.
After checking the RM and the imx6qdl.dtsi I'm not very sure that this
is right since the snvs-powerkey has a seperate irq-line. So we can be
sure that this irq is for us. If this is the case we don't need to check
the SNVS_LPSR_REG instead we only need to clear it.
Wouldn't we want to know if for some reason we get spurious interrupts?

Thanks.

-- 
Dmitry
Thread (10 messages) 10 messages, 3 authors, last reply 2020-07-30
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help