Re: [Linux-kernel-mentees] [PATCH v2] usbhid: Fix slab-out-of-bounds write in hiddev_ioctl_usage()
From: Dan Carpenter <hidden>
Date: 2020-07-23 14:51:39
Also in:
linux-kernel-mentees, linux-usb, lkml
On Mon, Jul 20, 2020 at 03:52:09PM -0400, Peilin Ye wrote:
`uref->usage_index` is not always being properly checked, causing hiddev_ioctl_usage() to go out of bounds under some cases. Fix it. Reported-by: syzbot+34ee1b45d88571c2fa8b@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?id=f2aebe90b8c56806b050a20b36f51ed6acabe802 Signed-off-by: Peilin Ye <redacted> --- Change in v2: - Add the same check for the `HIDIOCGUSAGE` case. (Suggested by Dan Carpenter [off-list ref])
Looks good to me. Thanks! Reviewed-by: Dan Carpenter <redacted> regards, dan carpenter