Re: [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages
From: Filipe Laíns <hidden>
Date: 2020-07-06 12:38:12
Also in:
lkml
Attachments
- signature.asc [application/pgp-signature] 833 bytes
From: Filipe Laíns <hidden>
Date: 2020-07-06 12:38:12
Also in:
lkml
On Sun, 2020-07-05 at 19:34 +0200, Maciej S. Szmigiero wrote:
These messages appear each time the mouse wakes from sleep, in my case (Logitech M705), every minute or so. Let's downgrade them to the "debug" level so they don't fill the kernel log by default. While we are at it, let's make clear that this is a wheel multiplier (and not, for example, XY movement multiplier). Fixes: 4435ff2f09a2 ("HID: logitech: Enable high-resolution scrolling on Logitech mice") Cc: stable@vger.kernel.org Signed-off-by: Maciej S. Szmigiero <redacted> --- Sending again since the previous message bounced for most recipients. drivers/hid/hid-logitech-hidpp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 1e1cf8eae649..b8b53dc95e86 100644--- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c@@ -3146,7 +3146,7 @@ static int hi_res_scroll_enable(structhidpp_device *hidpp) multiplier = 1; hidpp->vertical_wheel_counter.wheel_multiplier = multiplier; - hid_info(hidpp->hid_dev, "multiplier = %d\n", multiplier); + hid_dbg(hidpp->hid_dev, "wheel multiplier = %d\n", multiplier); return 0; }
I have seen this being useful in some cases, however I do not have a strong opinion on it. Peter would know better. Cheers, Filipe Laíns