Thread (11 messages) 11 messages, 5 authors, 2020-06-30

Re: input maintainer -- are you there? was Re: [PATCH 1/2] Input: add `SW_MACHINE_COVER`

From: Tony Lindgren <tony@atomide.com>
Date: 2020-06-30 18:04:18
Also in: linux-devicetree, linux-omap, lkml

* Pavel Machek [off-list ref] [200630 17:59]:
Hi!
quoted
quoted
quoted
Looks like we're blocking on this input patch.

On 16/06/2020 12:50, Pavel Machek wrote:
quoted
On Fri 2020-06-12 14:53:58, Merlijn Wajer wrote:
quoted
This event code represents the state of a removable cover of a device.
Value 0 means that the cover is open or removed, value 1 means that the
cover is closed.

Reviewed-by: Sebastian Reichel <redacted> Acked-by: Tony Lindgren 
[off-list ref] Signed-off-by: Merlijn Wajer [off-list ref] ---
Dmitry, can we get some kind of comment here, or better yet can we get you to apply this?
This is part of a patch series to resolve problems with the Nokia N900
not booting when the cover is removed (making the cover be the card
detect was also just weird IMHO). Just removing the card-detect from the
DTS is fine, but it was suggested that we expose the data instead as
input event. And that's gotten no response for about four months.

Should we just drop the feature and only remove the cd-gpios line from
the DTS, assuming upstream doesn't want this SW_MACHINE_COVER code?
I believe series is good, lets keep it. Changing now will only delay
it a bit more. Let me try to get Dmitry's attention...

If that does not work, we can get Linus' attention :-).

If that does not work, umm, there are some other options.
Sorry, am really swamped the last couple months. I can pick up the input
code, do you want me to pick up DTS as well?
No problem, sorry for being pushy.

If you could pick up just the input one-liner, that would be best. It
is not risky.

OMAP people will take care of the DTS, I believe, and we can iterate
if it does not work at the first try.
I already acked the dts change a while back, please just queue them
together. Or if you want me to pick it up, please set up an immutable
branch for me against v5.8-rc1 to also merge in :)

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help