Re: [PATCH v7] hwmon: add Corsair Commander Pro driver
From: Marius Zachmann <mail@mariuszachmann.de>
Date: 2020-06-26 13:36:14
Also in:
linux-doc, linux-hwmon, lkml
From: Marius Zachmann <mail@mariuszachmann.de>
Date: 2020-06-26 13:36:14
Also in:
linux-doc, linux-hwmon, lkml
On 26.06.20 at 15:21:35 CEST, Guenter Roeck wrote
On Fri, Jun 26, 2020 at 07:59:36AM +0200, Marius Zachmann wrote:quoted
This is v7 of a driver for the Corsair Commander Pro.Note to self: Reword when applying.quoted
It provides sysfs attributes for: - Reading fan speed - Reading temp sensors - Reading voltage values - Writing pwm and reading last written pwm - Reading fan and temp connection status It is an usb driver, so it needs to be ignored by usbhid. The Corsair Commander Pro is a fan controller and provides no means for user interaction. The two device numbers are there, because there is a slightly different version of the same device. (Only difference seem to be in some presets.) This is based on the staging/hwmon tree. Signed-off-by: Marius Zachmann <mail@mariuszachmann.de>Looks good. For my reference: Reviewed-by: Guenter Roeck <linux@roeck-us.net> We'll have to wait for an ACK from a HID maintainer before I can apply it. Thanks, Guenter
Thank you very much for your reviews and time! Marius