Thread (9 messages) 9 messages, 3 authors, 2020-05-24

Re: PROBLEM: Apple external Trackpad event timestamps are jittery (regression)

flat view

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2020-05-23 18:37:41

Hi,

On Fri, May 22, 2020 at 08:27:43AM +0300, Yariv wrote:
Some things I noticed: Gen2 didn't send "BTN_TOOL_FINGER" events,
while Gen1 did, even though I did not press any button. Note that Gen1
still had correct timestamps before the regression, even though it
sent these events.

Another difference (maybe it's the same one..): if you take a look at
the logs from my previous mail, you'll notice that Gen1 Trackpads
always send both SYN_REPORT (0) as well as SYN_REPORT (1), while 2nd
Gen Trackpads only sends SYN_REPORT (0).
So it looks like for Gen1 touchpads we set autorepeat, and it is that
autorepeat on BTN_TOOL_FINGER that gives what you consider jitter.

  - evdev:
    - [  0, 293648,   1, 325,       2] # EV_KEY / BTN_TOOL_FINGER           2
    - [  0, 293648,   0,   0,       1] # ------------ SYN_REPORT (1) ---------- +1ms
  - evdev:
    - [  0, 303026,   3,  48,      88] # EV_ABS / ABS_MT_TOUCH_MAJOR       88 (-12)
    - [  0, 303026,   3,  53,    -232] # EV_ABS / ABS_MT_POSITION_X      -232 (-22)
    - [  0, 303026,   3,  54,     291] # EV_ABS / ABS_MT_POSITION_Y       291 (+60)
    - [  0, 303026,   3,   0,    -232] # EV_ABS / ABS_X                  -232 (-22)
    - [  0, 303026,   3,   1,     291] # EV_ABS / ABS_Y                   291 (+60)
    - [  0, 303026,   0,   0,       0] # ------------ SYN_REPORT (0) ---------- +10ms

Can you please tell me what drivers are used by the 2 trackpads when they
are connected via Bluetooth? I think we should stop setting autorepeat in
the driver that handles Gen 1.

Also, can you post /proc/bus/input/devices?

Thanks.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help