Thread (8 messages) 8 messages, 2 authors, 2020-05-12

Re: [PATCH v2 1/4] dt-bindings: input: gpio-vibrator: Don't require enable-gpios

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2020-05-12 23:25:09
Also in: linux-arm-kernel, linux-devicetree, lkml

On Wed, May 13, 2020 at 01:05:57AM +0200, Ondřej Jirman wrote:
On Tue, May 12, 2020 at 03:52:12PM -0700, Dmitry Torokhov wrote:
quoted
On Wed, May 13, 2020 at 12:22:02AM +0200, Ondrej Jirman wrote:
quoted
It is possible to turn the motor on/off just by enabling/disabling
the vcc-supply.

Signed-off-by: Ondrej Jirman <redacted>
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/input/gpio-vibrator.yaml | 1 -
 1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/input/gpio-vibrator.yaml b/Documentation/devicetree/bindings/input/gpio-vibrator.yaml
index 2384465eaa19..c700b640bd53 100644
--- a/Documentation/devicetree/bindings/input/gpio-vibrator.yaml
+++ b/Documentation/devicetree/bindings/input/gpio-vibrator.yaml
@@ -24,7 +24,6 @@ properties:
 
 required:
   - compatible
-  - enable-gpios
Hmm we need at least one of the 2 (gpio and supply). Should we encode it
in the binding?
Not sure how to encode either one or the other property being required, but
not both at once.

Maybe I can add a supply-vibrator compatible to the driver and binding and
make requirements dependent on the compatible?
Rob is our bindings overlord... I'll defer to him here.

Thanks.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help