Re: [PATCH v3 2/2] Input: goodix - Fix spurious key release events
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2020-03-24 18:52:30
On Mon, Mar 16, 2020 at 10:53:05AM +0300, Dmitry Mastykin wrote:
The goodix panel sends spurious interrupts after a 'finger up' event, which always cause a timeout. We were exiting the interrupt handler by reporting touch_num == 0, but this was still processed as valid and caused the code to use the uninitialised point_data, creating spurious key release events. Report an error from the interrupt handler so as to avoid processing invalid point_data further. Signed-off-by: Dmitry Mastykin <redacted>
Applied, thank you.
quoted hunk ↗ jump to hunk
--- Changes in v3: - Improve commit message Changes in v2: - Improve commit message --- drivers/input/touchscreen/goodix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index 04b5c7b..cc965fe 100644 --- a/drivers/input/touchscreen/goodix.c +++ b/drivers/input/touchscreen/goodix.c@@ -329,7 +329,7 @@ static int goodix_ts_read_input_report(struct goodix_ts_data *ts, u8 *data) * The Goodix panel will send spurious interrupts after a * 'finger up' event, which will always cause a timeout. */ - return 0; + return -ENOMSG; } static void goodix_ts_report_touch_8b(struct goodix_ts_data *ts, u8 *coor_data)-- 2.23.0
-- Dmitry