On Thu, Feb 20, 2020 at 06:36:59PM -0800, Andrew Duggan wrote:

On 2/18/20 7:01 PM, Paul Hollinsky wrote:

quoted

Hi everyone,

I believe there may be an issue with the reduced reporting mode, at
least on my machine. I have a Lenovo ThinkPad X250 with the Synaptics
TM3075-002 trackpad.

With this patch, the trackpad becomes unusable. On a reboot, my control
register values are [38 00 19 19 00 10 90 06 ea 03 0f 01]. This
corresponds to a delta X/Y threshold of 25 and a palm rejection value of
0. The protocol documentation mentions that the palm rejection value
becomes active when in reduced reporting mode, hence its inclusion here.

Hmm, it looks like the firmware was configured with non-zero Delta X/Y
Position thresholds. But, the firmware does not enable reduced reporting
mode by default so those thresholds have no effect. However, this patch will
now enable reduced reporting mode since it sees the non-zero threshold which
were read from the firmware. I did not consider the case where the firmware
would have thresholds set, but not enabled when I reviewed this patch
initially. Based on this new info I would suggest we change the if statement
to check sensor->axis_align.delta_x_threshold ||
sensor->axis_align.delta_y_threshold. Then we would only change the
reporting mode if the driver is explicitly setting the thresholds.

Any chance I could get a patch implementing this?

Thanks.

-- 
Dmitry