Re: [PATCH resend 04/10] Input: goodix - Add support for getting IRQ + reset GPIOs on Cherry Trail devices

Hi,

On 3/2/20 4:44 PM, Bastien Nocera wrote:

On Mon, 2020-03-02 at 16:40 +0100, Hans de Goede wrote:

quoted

quoted

Does this mean we retry at most once?

Yes, we are not really "retrying", we are doing a 2 step

probe:



1) First try to get the GPIOs without having done our heuristics and

without having called devm_acpi_dev_add_driver_gpios(). This is for

ACPI platforms extra GPIO info (including names) using the special

ACPI "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" UUID method.



2) If this fails then we add our own name to index mappings and

get the GPIOs using those.

Is there a better way to communicate that? Using a separate function
for that piece of code,

The code adding our own mappings already is in a separate function, that
is what the goodix_add_acpi_gpio_mappings function is for.

and maybe some comments to clarify what it's
doing.

I will add a comment above the goodix_add_acpi_gpio_mappings function
explaining that it is used to add our own mappings if the ACPI
tables do not contain GPIO-name to ACPI resource index mappings.

Regards,

Hans