Re: [PATCH v9 13/55] Input: atmel_mxt_ts - add regulator control support

Hi Dmitry

On 2020/03/30 3:54, Dmitry Osipenko wrote:

27.03.2020 14:09, Wang, Jiada пишет:

quoted

Hi Dmitry

On 2020/03/26 4:05, Dmitry Osipenko wrote:

quoted

25.03.2020 16:32, Jiada Wang пишет:

quoted

From: Nick Dyer <redacted>

Allow the driver to optionally manage enabling/disable power to the
touch
controller itself. If the regulators are not present then use the deep
sleep power mode instead.

For a correct power on sequence, it is required that we have control
over
the RESET line.

...

quoted

+    data->reg_vdd = devm_regulator_get(dev, "vdd");
+    if (IS_ERR(data->reg_vdd)) {
+        error = PTR_ERR(data->reg_vdd);
+        dev_err(dev, "Error %d getting vdd regulator\n", error);
+        goto fail;
+    }
+
+    data->reg_avdd = devm_regulator_get(dev, "avdd");
+    if (IS_ERR(data->reg_avdd)) {
+        error = PTR_ERR(data->reg_avdd);
+        dev_err(dev, "Error %d getting avdd regulator\n", error);
+        goto fail_release;
+    }

Hello Jiada,

The new regulator properties should be documented in the device-tree
binding.

I will document new regulator properties in a separate commit in
v10 patch-set

Please make sure that all patches are added in a correct order and that
they at least compile. This patch doesn't compile:

Sure, I will take care of this issue in next version

Thanks,
Jiada

   CC      drivers/input/touchscreen/atmel_mxt_ts.o
drivers/input/touchscreen/atmel_mxt_ts.c:34:10: fatal error:
dt-bindings/input/atmel_mxt_ts.h: No such file or directory
    34 | #include <dt-bindings/input/atmel_mxt_ts.h>