On Wed, Feb 12, 2020 at 09:53:25AM +0100, Benjamin Tissoires wrote:

On Wed, Jan 15, 2020 at 2:30 AM Benjamin Tissoires
[off-list ref] wrote:

quoted

The Yoga 11e is using LEN0049, but it doesn't have a trackstick.

Thus, there is no need to create a software top buttons row.

However, it seems that the device works under SMBus, so keep it as part
of the smbus_pnp_ids.


Link: https://gitlab.freedesktop.org/libinput/libinput/issues/414
Signed-off-by: Benjamin Tissoires <redacted>

--

Hi Dmitry,

Sending the patch to the list untested (sanity only), and I'll ask
for the reporter to provide a little bit more testing.

I will keep you updated when you can merge the patch.

Hi Dmitry,

Sergej tested the patch last week and it works well. So I think we can
merge it now.
Maybe we should also add a stable@ tag here...

Tagged for stable, thank you Benjamin.

Cheers,
Benjamin

quoted

Cheers,
Benjamin
---
 drivers/input/mouse/synaptics.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 1ae6f8bba9ae..7aa84f743c48 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c

@@ -146,7 +146,6 @@ static const char * const topbuttonpad_pnp_ids[] = {
        "LEN0042", /* Yoga */
        "LEN0045",
        "LEN0047",
-       "LEN0049",
        "LEN2000", /* S540 */
        "LEN2001", /* Edge E431 */
        "LEN2002", /* Edge E531 */

@@ -166,6 +165,7 @@ static const char * const smbus_pnp_ids[] = {
        /* all of the topbuttonpad_pnp_ids are valid, we just add some extras */
        "LEN0048", /* X1 Carbon 3 */
        "LEN0046", /* X250 */
+       "LEN0049", /* Yoga 11e */
        "LEN004a", /* W541 */
        "LEN005b", /* P50 */
        "LEN005e", /* T560 */
--

2.24.1

-- 
Dmitry