Re: [PATCH] HID: Add quirk for Apple Magic Keyboard over Bluetooth
From: Benjamin Tissoires <hidden>
Date: 2020-01-31 09:18:39
Hi Daniel, On Thu, Jan 30, 2020 at 8:31 PM Daniel Lockyer [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The Apple Magic Keyboard works flawlessly over USB but has weird bugs over Bluetooth. This patch adds the missing quirk. Signed-off-by: Daniel Lockyer <redacted> --- drivers/hid/hid-quirks.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c index 0e7b2d998395..6d68a9201e1d 100644 --- a/drivers/hid/hid-quirks.c +++ b/drivers/hid/hid-quirks.c@@ -280,6 +280,7 @@ static const struct hid_device_id hid_have_special_driver[] = { { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ANSI) }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ISO) }, { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_JIS) }, + { HID_BLUETOOTH_DEVICE(BT_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_ANSI) },
That is weird. The whole purpose of this list (which I'd like to remove in the future) is to prevent hid-generic to ever bind to those devices. This can be problematic in situations where you do not have the corresponding driver, in the initrd for instance. Can you share your dmesg before and after applying this patch so I get a grasp on why you need that change? Cheers, Benjamin
{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_ANSI) },
{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_FOUNTAIN_TP_ONLY) },
{ HID_USB_DEVICE(USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY) },
--
2.25.0