Thread (4 messages) 4 messages, 2 authors, 2020-01-15

Re: [PATCH 1/1] HID: hiddev: remove a duplicated check

From: Leizhen (ThunderTown) <hidden>
Date: 2020-01-15 02:58:47
Also in: linux-usb


On 2020/1/14 22:19, Jiri Kosina wrote:
On Tue, 14 Jan 2020, Leizhen (ThunderTown) wrote:
quoted
Does no one pay attention to this problem? Although there is no
functional problem, but it seems confusing.

        if (!list->hiddev->exist) {                 <---------
                res = -ENODEV;                                |
                goto bail_unlock;                             |
        }                                                     |
        if (!list->hiddev->open++)                            |
                if (list->hiddev->exist) {          <--------- //It's always true.
This code no longer exists after refactoring that happened in commit 
18a1b06e5b91d47.
OK
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help