Re: [PATCH v3 4/6] Input: edt-ft5x06 - make wakeup-source switchable
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2020-01-10 01:07:16
Also in:
linux-devicetree
On Wed, Jan 08, 2020 at 12:10:48PM +0100, Marco Felsch wrote:
Since day one the touch controller acts as wakeup-source. This seems to be wrong since the device supports deep-sleep mechanism [1] which requires a reset to leave it. Also some designs won't use the touchscreen as wakeup-source. According discussion [2] we decided to break backward compatibility and go the common way by using the 'wakeup-source' device-property. [1] https://www.newhavendisplay.com/appnotes/datasheets/touchpanel/FT5x26.pdf [2] https://patchwork.kernel.org/patch/11149037/ Signed-off-by: Marco Felsch <redacted> Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied, thank you.
quoted hunk ↗ jump to hunk
--- v3: - make use of i2c-core wakeup-source handling v2: - make use of common wakeup-source property - adapt commit message --- drivers/input/touchscreen/edt-ft5x06.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c index e1b31fd525e2..c781952c3409 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c@@ -1208,7 +1208,6 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client, return error; edt_ft5x06_ts_prepare_debugfs(tsdata, dev_driver_string(&client->dev)); - device_init_wakeup(&client->dev, 1); dev_dbg(&client->dev, "EDT FT5x06 initialized: IRQ %d, WAKE pin %d, Reset pin %d.\n",-- 2.20.1
-- Dmitry