Re: [PATCH v4] HID: core: check whether Usage Page item is after Usage ID items
From: Candle Sun <hidden>
Date: 2019-11-13 09:40:53
Also in:
lkml
On Wed, Nov 13, 2019 at 9:08 AM Candle Sun [off-list ref] wrote:
On Tue, Nov 12, 2019 at 11:18 PM Benjamin Tissoires [off-list ref] wrote:quoted
Hi all, On Tue, Nov 12, 2019 at 2:57 PM Jiri Kosina [off-list ref] wrote:quoted
On Tue, 22 Oct 2019, Candle Sun wrote:quoted
From: Candle Sun <redacted> Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation to Main item") adds support for Usage Page item after Usage ID items (such as keyboards manufactured by Primax).[ ... snip ... ] Benjamin, are you planning to run this through your testsuite against regressions? I believe that's the last missing step, otherwise I'd be fine merging this.Sorry I had to deal with family issues 2 weeks ago, and now RHEL is coming back at me and eating all my time. The kernel patch is now OK, so we can grab it now (either you take it Jiri, and add my acked-by or I'll push it later...) Candle, can you rework https://gitlab.freedesktop.org/libevdev/hid-tools/merge_requests/58 so that it mirrors the kernel code (and get rid of the self.local.usage_page_last logic)? Cheers, BenjaminThanks Jiri and Benjamin. I will rework the hid-tools patch ASAP. Regards, Candle
Hi Benjamin, The MR for hid-tools is updated: https://gitlab.freedesktop.org/libevdev/hid-tools/merge_requests/62 Thanks, Candle
quoted
quoted
Thanks, -- Jiri Kosina SUSE Labs