Thread (4 messages) 4 messages, 2 authors, 2019-11-11

Re: [PATCH 8/8] Input: input_event: fix struct padding on sparc64

From: Arnd Bergmann <arnd@arndb.de>
Date: 2019-11-11 19:18:34
Also in: lkml, sparclinux, stable

On Mon, Nov 11, 2019 at 7:28 PM Dmitry Torokhov
[off-list ref] wrote:
I do not like ifdefs here, do you think we could write:

                client->buffer[client->tail] = (struct input_event) {
                        .input_event_sec = event->input_event_sec,
                        .input_event_usec = event->input_event_usec,
                        .type = EV_SYN,
                        .code = SYN_DROPPED,
                };

to ensure all padded fields are initialized? This is not hot path as we
do not expect queue to overfill too often.
Good idea, changed both instances now. Thanks for taking a look!

      Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help