Re: [PATCH v6 1/6] HID: joycon: add nintendo switch controller driver
From: Daniel Ogorchock <djogorchock@gmail.com>
Date: 2019-10-09 01:22:09
On Mon, Oct 7, 2019 at 10:14 AM Jiri Kosina [off-list ref] wrote:
On Sun, 15 Sep 2019, Daniel J. Ogorchock wrote:quoted
The joycon driver supports the Nintendo Switch Pro Controllers and the Joy-Cons. The Pro Controllers can be used over USB or Bluetooth. The Joy-Cons each create their own, independent input devices, so it is up to userspace to combine them if desired. Signed-off-by: Daniel J. Ogorchock <djogorchock@gmail.com> --- MAINTAINERS | 6 + drivers/hid/Kconfig | 11 + drivers/hid/Makefile | 1 + drivers/hid/hid-ids.h | 3 + drivers/hid/hid-joycon.c | 820 +++++++++++++++++++++++++++++++++++++++Hi Daniel, I've finally (sorry for the delay) through reviewing these patches. All looks good and ready to be merged, the only last request I'd have -- could we please have this called hid-nintendo instead? We've been going on with the per-vendor driver naming for quite some time already. If you agree with that, let's get this queued for 5.5. Thanks, -- Jiri Kosina SUSE Labs
Hi Jiri, Yes, I can change the name to hid-nintendo. I'll try to get a new patchset submitted in the next week with the name change and the code improvements Silvan mentioned in his review of this patchset. Thanks, Daniel Ogorchock