Re: [PATCH v2] HID: hidraw: replace printk() with corresponding pr_xx() variant
flat view
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2019-09-19 16:16:19
Also in:
lkml
Hi Rishi, On Wed, Sep 18, 2019 at 09:59:11PM +0530, Rishi Gupta wrote:
quoted hunk ↗ jump to hunk
This commit replaces direct invocations of printk with their appropriate pr_info/warn() variant. Signed-off-by: Rishi Gupta <gupt21@gmail.com> --- Changes in v2: - Removed manually adding prefix "hidraw:". drivers/hid/hidraw.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c index 006bd6f..2d082f3 100644 --- a/drivers/hid/hidraw.c +++ b/drivers/hid/hidraw.c@@ -197,14 +197,14 @@ static ssize_t hidraw_get_report(struct file *file, char __user *buffer, size_t } if (count > HID_MAX_BUFFER_SIZE) { - printk(KERN_WARNING "hidraw: pid %d passed too large report\n", + pr_warn("pid %d passed too large report\n", task_pid_nr(current));
It looks like here and in the instance below you actually have a hid device, so you can use hid_warn() instead of pr_warn(), similarly to hidraw_send_report(). The change to pr_info() in hidraw_init() is good. Thanks. -- Dmitry