Thread (15 messages) 15 messages, 2 authors, 2019-08-23

Re: [PATCH 00/11] Face lift for bu21013_ts driver

From: Linus Walleij <hidden>
Date: 2019-08-23 11:30:37
Also in: lkml

On Wed, Aug 21, 2019 at 7:43 PM Dmitry Torokhov
[off-list ref] wrote:
The issue is this:

static void bu21013_disable_chip(void *_ts)
{
        struct bu21013_ts *ts = ts;

which shuts up gcc about the fact that 'ts' is uninitialized, it should
have said "ts = _ts". I guess it is a lesson for me to not call the voi
d pointer argument almost the same name as the structure, as it is easy
to miss in the review. The compiler would not care in either case, but a
human might have noticed.

Can you please try making this change (and the same in power off
handler)?
Yes this works! :)

Tested-by: Linus Walleij <redacted>

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help