Re: [PATCH v5 15/17] mfd: ioc3: Add driver for SGI IOC3 chip
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Date: 2019-08-20 06:23:15
Also in:
linux-doc, linux-mips, linux-rtc, linux-serial, lkml, netdev
Hi, On 19/08/2019 18:31:38+0200, Thomas Bogendoerfer wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/mfd/ioc3.c b/drivers/mfd/ioc3.c new file mode 100644 index 000000000000..5bcb3461a189 --- /dev/null +++ b/drivers/mfd/ioc3.c@@ -0,0 +1,586 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * SGI IOC3 multifunction device driver + * + * Copyright (C) 2018, 2019 Thomas Bogendoerfer <tbogendoerfer@suse.de> + * + * Based on work by: + * Stanislaw Skowronek <skylark@unaligned.org> + * Joshua Kinard <kumba@gentoo.org> + * Brent Casavant <bcasavan@sgi.com> - IOC4 master driver + * Pat Gefre <pfg@sgi.com> - IOC3 serial port IRQ demuxer + */ + +#include <linux/delay.h> +#include <linux/errno.h> +#include <linux/interrupt.h> +#include <linux/mfd/core.h> +#include <linux/module.h> +#include <linux/pci.h> +#include <linux/platform_device.h> +#include <linux/platform_data/sgi-w1.h> +#include <linux/rtc/ds1685.h>
I don't think this include is necessary. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com