Re: [PATCH v2 0/4] Read battery voltage from G403 and G900 mice
From: Filipe Laíns <hidden>
Date: 2019-08-19 13:44:34
Also in:
lkml
Attachments
- signature.asc [application/pgp-signature] 833 bytes
From: Filipe Laíns <hidden>
Date: 2019-08-19 13:44:34
Also in:
lkml
On Wed, 2019-06-05 at 15:45 -0400, Pedro Vanzella wrote:
The gaming line of Logitech devices doesn't use the old hidpp20 feature for battery level reporting. Instead, they report the current voltage of the battery, in millivolts. This patch set handles this case by adding a quirk to the devices we know to have this new feature, in both wired and wireless mode. This version of the patch set is better split, as well as adding the quirk to make sure we don't needlessly probe every device connected. Pedro Vanzella (4): HID: hid-logitech-hidpp: add quirk to handle battery voltage HID: hid-logitech-hidpp: add function to query battery voltage HID: hid-logitech-hidpp: report battery voltage to the power supply HID: hid-logitech-hidpp: subscribe to battery voltage events drivers/hid/hid-logitech-hidpp.c | 150 ++++++++++++++++++++++++++++++- 1 file changed, 147 insertions(+), 3 deletions(-)
This is OK. However since we now have a feature discovery routine I think the code should use that instead of quirks. I will send a patch making this change. You can have my Reviewed-by: Filipe Laíns <redacted> Thank you, Filipe Laíns