Re: [PATCH] HID: logitech-dj: Fix check of logi_dj_recv_query_paired_devices()
From: Hans de Goede <hidden>
Date: 2019-07-31 11:29:39
Also in:
lkml
From: Hans de Goede <hidden>
Date: 2019-07-31 11:29:39
Also in:
lkml
Hi Petr, On 31-07-19 13:06, Petr Vorel wrote:
Hi,quoted
quoted
In delayedwork_callback(), logi_dj_recv_query_paired_devices may return positive value while success now, so check it correctly.quoted
quoted
Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices") Signed-off-by: YueHaibing <redacted>Reviewed-by: Petr Vorel <pvorel@suse.cz>OK, not only it didn't fix problems with logitech mouse (see below), but removing mouses USB dongle effectively crashes kernel, so this one probably shouldn't be applied :). [ 330.721629] logitech-djreceiver: probe of 0003:046D:C52F.0013 failed with error 7 [ 331.462335] hid 0003:046D:C52F.0013: delayedwork_callback: logi_dj_recv_query_paired_devices error: 7
Please test my patch titled: "HID: logitech-dj: Really fix return value of logi_dj_recv_query_hidpp_devices" which should fix this. Regards, Hans