Re: [PATCH v2 3/3] HID: core: only warn once of oversize hid report
From: Joe Perches <joe@perches.com>
Date: 2019-07-22 21:31:02
Also in:
lkml
On Mon, 2019-07-22 at 15:26 -0600, stillcompiling@gmail.com wrote:
From: Joshua Clayton <redacted>
Thanks Joshua
On HP spectre x360 convertible the message: hid-sensor-hub 001F:8087:0AC2.0002: hid_field_extract() called with n (192) > 32! (kworker/1:2) is continually printed many times per second, crowding out all else Protect dmesg by printing the warning only one time.
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
[]
quoted hunk ↗ jump to hunk
@@ -1311,8 +1311,8 @@ u32 hid_field_extract(const struct hid_device *hid, u8 *report, unsigned offset, unsigned n) { if (n > 32) { - hid_warn(hid, "hid_field_extract() called with n (%d) > 32! (%s)\n", - n, current->comm); + hid_warn_once(hid, "%s() called with n (%d) > 32! (%s)\n", + __func__ ,n , current->comm);
All the other bits are fine, but this line is oddly written with unusual spacing around 'n'. Normally it'd be something like: hid_warn_once(hid, "%s: called with n (%d) > 32! (%s)\n", __func__, n, current->comm);