Thread (11 messages) 11 messages, 4 authors, 2019-07-01

Re: [PATCH 2/2] Input: edt-ft5x06 - simplify event reporting code

From: Andy Shevchenko <hidden>
Date: 2019-06-23 07:59:32
Also in: lkml

On Sun, Jun 23, 2019 at 9:31 AM Dmitry Torokhov
[off-list ref] wrote:
Now that input_mt_report_slot_state() returns true if slot is active we no
longer need a temporary for the slot state.
-               down = type != TOUCH_EVENT_UP;

                input_mt_slot(tsdata->input, id);
-               input_mt_report_slot_state(tsdata->input, MT_TOOL_FINGER, down);
+               if (input_mt_report_slot_state(tsdata->input, MT_TOOL_FINGER,
+                                              type != TOUCH_EVENT_UP))
Can't we simple do somethink like
-               down = type != TOUCH_EVENT_UP;
+               down = input_mt_report_slot_state(tsdata->input,
MT_TOOL_FINGER, type != TOUCH_EVENT_UP);

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help