Re: [PATCH] Input: cros_ec_keyb: mask out extra flags in event_type
From: Enric Balletbo i Serra <hidden>
Date: 2019-06-18 08:43:28
Also in:
lkml
From: Enric Balletbo i Serra <hidden>
Date: 2019-06-18 08:43:28
Also in:
lkml
On 14/6/19 8:54, Ting Shen wrote:
http://crosreview.com/1341159 added a EC_MKBP_HAS_MORE_EVENTS flag to the event_type field, the receiver side should mask out this extra bit when processing the event. Signed-off-by: Ting Shen <redacted> --- drivers/input/keyboard/cros_ec_keyb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c index d5600118159835..38cb6d82d8fe67 100644 --- a/drivers/input/keyboard/cros_ec_keyb.c +++ b/drivers/input/keyboard/cros_ec_keyb.c@@ -237,7 +237,7 @@ static int cros_ec_keyb_work(struct notifier_block *nb, if (queued_during_suspend && !device_may_wakeup(ckdev->dev)) return NOTIFY_OK; - switch (ckdev->ec->event_data.event_type) { + switch (ckdev->ec->event_data.event_type & EC_MKBP_EVENT_TYPE_MASK) { case EC_MKBP_EVENT_KEY_MATRIX: pm_wakeup_event(ckdev->dev, 0);
Applied for chrome-platform-5.3 Thanks, ~ Enric